Remove OwnerReferences from CA configmaps

[rubenvp8510]

Signed-off-by: Ruben Vargas [email protected]

This change is to avoid ConfigMaps which are not in the same namespace as the operator from being garbage collected.

As the documentation says:

Cross-namespace owner references are disallowed by design.
Namespaced dependents can specify cluster-scoped or namespaced owners. A namespaced owner must exist in the same namespace as the dependent. If it does not, the owner reference is treated as absent, and the dependent is subject to deletion once all owners are verified absent.

https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/

Which problem is this PR solving?

• This solves an issue that deletes CA/Service CA ConfigMaps from sidecars that are not in the same namespace as the operator.

Short description of the changes

• Removed the OwnerReferences from ConfigMaps
• Implemented a deletion logic for those ConfigMaps when a Jaeger instance is deleted.

NOTE: The clean up process consider that there is no more than one Jaeger instance with the same name on the cluster. I think we did this assumption for other parts of the code, so I don't think this will be a problem for now.

[codecov]

Codecov Report

Merging #1467 (b5f7f33) into master (32e8f54) will decrease coverage by 0.17%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #1467      +/-   ##
==========================================
- Coverage   87.33%   87.15%   -0.18%     
==========================================
  Files          90       90              
  Lines        4982     4983       +1     
==========================================
- Hits         4351     4343       -8     
- Misses        478      484       +6     
- Partials      153      156       +3     

Impacted Files	Coverage Δ
pkg/config/ca/ca.go	100.00% <ø> (ø)
pkg/controller/jaeger/jaeger_controller.go	37.01% <0.00%> (-0.77%)	⬇️
pkg/controller/jaeger/configmap.go	68.08% <56.25%> (-6.11%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e8f54...b5f7f33. Read the comment docs.

[rubenvp8510]

Struggling to reach the desired coverage due the tests can't reach error blocks.

[jpkrohling]

Looks good, just need to properly format the imports and document why errors are being swallowed.