Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to indicate PriorityClass for agent #1392

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Add ability to indicate PriorityClass for agent #1392

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
366f2fa
signoff
Feb 15, 2021
1dfa273
add example
Feb 15, 2021
41676e2
add details in example
Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions examples/agent-with-priority-class.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
name: agent-as-daemonset
spec:
agent:
strategy: DaemonSet
PriorityClassName: test # priorityClassName here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PriorityClassName: test # priorityClassName here
priorityClassName: test # priorityClassName here

This example should include an example of a priority class, like (from the documentation):

apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
  name: high-priority
value: 1000000
globalDefault: false
description: "This priority class should be used for XYZ service pods only."

If you use this in the example, don't forget to change the name to high-priority in the Jaeger CR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sorry.
added changes as above
@jpkrohling pls review