Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate jaeger.tags in existing CRs #1380

Merged

Conversation

jpkrohling
Copy link
Contributor

This commit adds a migration for existing CRs, moving from the deprecated jaeger.tags to collector.tags or agent.tags, according to the components being used.

Signed-off-by: Juraci Paixão Kröhling [email protected]

@mergify mergify bot requested a review from rubenvp8510 February 4, 2021 13:46
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1380 (df33051) into master (b3fd44a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
+ Coverage   86.67%   86.70%   +0.02%     
==========================================
  Files          89       90       +1     
  Lines        5006     5017      +11     
==========================================
+ Hits         4339     4350      +11     
  Misses        513      513              
  Partials      154      154              
Impacted Files Coverage Δ
pkg/upgrade/v1_22_0.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3fd44a...df33051. Read the comment docs.

@jpkrohling jpkrohling requested review from objectiser and removed request for rubenvp8510 February 4, 2021 13:54
@mergify mergify bot requested a review from rubenvp8510 February 4, 2021 13:54
@jpkrohling jpkrohling removed the request for review from rubenvp8510 February 4, 2021 13:55
@mergify mergify bot requested a review from rubenvp8510 February 4, 2021 13:56
Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one minor comment, but if you want to leave it, I will approve as is.

pkg/upgrade/v1_22_0_test.go Outdated Show resolved Hide resolved
This commit adds a migration for existing CRs, moving from the deprecated jaeger.tags to collector.tags or agent.tags, according to the components being used.

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling force-pushed the jpkrohling/1378-migrate-jaeger-tags branch from 93d6613 to df33051 Compare February 4, 2021 14:19
@mergify mergify bot merged commit 883ae48 into jaegertracing:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants