Fix way we force es secret reconcile #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Earls <[email protected]>
|
@jpkrohling Please review |
Codecov Report
@@ Coverage Diff @@
## master #1374 +/- ##
=======================================
Coverage 86.22% 86.22%
=======================================
Files 90 90
Lines 5146 5146
=======================================
Hits 4437 4437
Misses 539 539
Partials 170 170 Continue to review full report at Codecov.
|
jpkrohling
reviewed
Jan 28, 2021
scripts/cert_generation.sh
Outdated
| @@ -209,7 +209,9 @@ function generate_certs() { | |||
|
|
|||
| # For TRACING-1631 - if we can't find the namespace in the cert it's bad, regenerate everything | |||
| if [ $REGENERATE_NEEDED = 0 ] && [ "${component}" == "elasticsearch" ] && [ -f ${WORKING_DIR}/logging-es.crt ] ; then | |||
| openssl x509 -in ${WORKING_DIR}/logging-es.crt -text | grep -q "DNS:elasticsearch.${NAMESPACE}.svc" | |||
| # Make sure the SAN contains both "DNS:elasticsearch.${NAMESPACE}.svc.cluster.local" AND "DNS:elasticsearch.${NAMESPACE}.svc. | |||
| # The latter may be followed by a comma or whitespace | |||
There was a problem hiding this comment.
Sounds strange. Any reasons why?
There was a problem hiding this comment.
Sorry, let me fix that
Signed-off-by: Kevin Earls <[email protected]>
jpkrohling
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Earls [email protected]