Create missing CA config maps on deployment controller #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
force-pushed
the
jpkrohling/create-missing-ca-configmaps
branch
2 times, most recently
from
bfb88bf to
5db2056
Compare
Codecov Report
@@ Coverage Diff @@
## master #1347 +/- ##
==========================================
+ Coverage 86.02% 86.23% +0.20%
==========================================
Files 90 90
Lines 5125 5143 +18
==========================================
+ Hits 4409 4435 +26
+ Misses 548 538 -10
- Partials 168 170 +2
Continue to review full report at Codecov.
|
|
LGTM |
jpkrohling
force-pushed
the
jpkrohling/create-missing-ca-configmaps
branch
from
5db2056 to
a891a1d
Compare
objectiser
previously approved these changes
Dec 15, 2020
rubenvp8510
previously approved these changes
Dec 15, 2020
mergify
bot
dismissed stale reviews from objectiser and rubenvp8510
Pull request has been modified.
|
Why the change from patch to update? |
objectiser
reviewed
Dec 15, 2020
| @@ -108,74 +109,61 @@ func (r *ReconcileDeployment) Reconcile(request reconcile.Request) (reconcile.Re | |||
| err = r.rClient.Get(ctx, types.NamespacedName{Name: request.Namespace}, ns) | |||
There was a problem hiding this comment.
@jpkrohling @rubenvp8510 What is the difference between the r.rClient and r.client? Seems both are used in this class?
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
jpkrohling/create-missing-ca-configmaps
branch
from
a408d7a to
8c5f86f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the deployment controller so that it always attempt to create the configmaps in the namespace for the target deployments, as long as sidecar injection is desired for the deployment.
Signed-off-by: Juraci Paixão Kröhling [email protected]