Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the codeql.yml #1313

Merged
merged 4 commits into from
Jan 27, 2021
Merged

Conversation

KrishnaSindhur
Copy link
Contributor

#1291

Added the codeql checks

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #1313 (09a281d) into master (462dabe) will decrease coverage by 1.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
- Coverage   87.37%   86.22%   -1.16%     
==========================================
  Files          89       90       +1     
  Lines        4976     5146     +170     
==========================================
+ Hits         4348     4437      +89     
- Misses        465      539      +74     
- Partials      163      170       +7     
Impacted Files Coverage Δ
pkg/strategy/controller.go 93.33% <0.00%> (-1.74%) ⬇️
pkg/controller/deployment/deployment_controller.go 33.62% <0.00%> (ø)
pkg/cronjob/spark_dependencies.go 93.13% <0.00%> (+0.13%) ⬆️
pkg/inject/sidecar.go 94.93% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 462dabe...09a281d. Read the comment docs.

@KrishnaSindhur
Copy link
Contributor Author

@jpkrohling can u review this, its my first PR in this repo

@jpkrohling
Copy link
Contributor

Could you please take a look at the DCO check?

krishna sindhur added 3 commits January 26, 2021 22:42
Signed-off-by: krishna sindhur <[email protected]>
Signed-off-by: krishna sindhur <[email protected]>
Signed-off-by: krishna sindhur <[email protected]>
@KrishnaSindhur
Copy link
Contributor Author

Could you please take a look at the DCO check?

sure done

@jpkrohling jpkrohling merged commit 2994530 into jaegertracing:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants