Update UI documentation link if is present #1290
Conversation
rubenvp8510
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1290 +/- ##
==========================================
- Coverage 87.32% 87.30% -0.03%
==========================================
Files 89 89
Lines 4947 4970 +23
==========================================
+ Hits 4320 4339 +19
- Misses 464 466 +2
- Partials 163 165 +2
Continue to review full report at Codecov.
|
rubenvp8510
force-pushed
the
update-doc-link
branch
from
ef00bc3 to
96db555
Compare
Signed-off-by: Ruben Vargas Palma <[email protected]>
rubenvp8510
force-pushed
the
update-doc-link
branch
from
96db555 to
bf0fcfa
Compare
| if !ok { | ||
| return false, 0 | ||
| } | ||
| if itemLabel, ok := itemMap["label"]; ok && itemLabel == "Documentation" { |
There was a problem hiding this comment.
Do we set this initially, or is it only set by users? Can we somehow check whether the value was set by us? We should really avoid changing a value that was set by users.
There was a problem hiding this comment.
As this issue is related to the doc URL being supplied via CLI flag, can we just provide a fix for that situation (i.e. check if the CLI flag has been defined)?
There was a problem hiding this comment.
@jpkrohling TBH I don't like this either, unfortunately there is not a way to know if this was set by us or, not that I'm aware of. :(
@objectiser This code is only executed if the documentation flag is set, See: https://github.com/jaegertracing/jaeger-operator/pull/1290/files#diff-8be2eee66bfcb8efd08e4b1fe2795663a53935ff150187ad426d371534045b01R258
The update of the doc will be only executed if the CLI flag is set, there is something on the menu, and the menu structure and labels match.
There was a problem hiding this comment.
@jpkrohling In this situation, if the doc URL is specified via CLI, could we just take that as the true value - so not overridden by user defined value?
|
About the decrease in the code coverage: looks like the error conditions aren't being tested:
|
Fixes #1292
Signed-off-by: Ruben Vargas Palma [email protected]