-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add env var JAEGER_DISABLED #1285
Merged
mergify
merged 3 commits into
jaegertracing:master
from
sschne:feature/query-jaeger-disabled
Nov 10, 2020
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -251,6 +251,12 @@ type JaegerQuerySpec struct { | |
// The default, if omitted, is ClusterIP. | ||
// See https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types | ||
ServiceType v1.ServiceType `json:"serviceType,omitempty"` | ||
|
||
// +optional | ||
// JaegerDisabled adds the JAEGER_DISABLED environment flag to the | ||
// query component to prevent it from adding its own traces. | ||
// The default, if ommited, is false | ||
JaegerDisabled *bool `json:"jaegerDisabled,omitempty"` | ||
} | ||
|
||
// JaegerUISpec defines the options to be used to configure the UI | ||
|
@@ -341,6 +347,12 @@ type JaegerAllInOneSpec struct { | |
|
||
// +optional | ||
JaegerCommonSpec `json:",inline,omitempty"` | ||
|
||
// +optional | ||
// JaegerDisabled adds the JAEGER_DISABLED environment flag to the | ||
// query component to prevent it from adding its own traces. | ||
// The default, if ommited, is false | ||
JaegerDisabled *bool `json:"jaegerDisabled,omitempty"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. |
||
} | ||
|
||
// AutoScaleSpec defines the common elements used for create HPAs | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better calling it
tracingEnabled
- with a default oftrue
?