Use New Admin Port Flag #1281
Merged
Use New Admin Port Flag #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1281 +/- ##
==========================================
+ Coverage 87.31% 87.32% +0.01%
==========================================
Files 90 90
Lines 4942 4947 +5
==========================================
+ Hits 4315 4320 +5
Misses 464 464
Partials 163 163
Continue to review full report at Codecov.
|
jpkrohling
reviewed
Oct 28, 2020
johanavril
force-pushed
the
use-new-flag
branch
from
49ba53e to
80ee898
Compare
jpkrohling
reviewed
Oct 29, 2020
pkg/util/util_test.go
Outdated
| @@ -353,6 +353,35 @@ func TestGetPortSpecified(t *testing.T) { | |||
| assert.Equal(t, int32(6831), GetPort("--processor.jaeger-compact.server-host-port=", args, 1234)) | |||
| } | |||
|
|
|||
| func TestGetAdminPortDefault(t *testing.T) { | |||
There was a problem hiding this comment.
This looks good, but you could have used a table test here, with the args, the default port and the expected outcome as the test's struct:
There was a problem hiding this comment.
That looks better, will change to table test now
will check the new flag for retrieving admin port and if not available will use the old one instead Signed-off-by: johanavril <[email protected]>
johanavril
force-pushed
the
use-new-flag
branch
from
80ee898 to
74514ea
Compare
jpkrohling
approved these changes
Oct 29, 2020
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1276