Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix these tests to work properly when using OTEL images #1280

Merged
merged 2 commits into from
Oct 28, 2020
Merged

Fix these tests to work properly when using OTEL images #1280

merged 2 commits into from
Oct 28, 2020

Conversation

kevinearls
Copy link
Contributor

Signed-off-by: Kevin Earls [email protected]

i.e. when using 2.0 and running with SPECIFY_OTEL_ONFIG set to true

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #1280 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1280   +/-   ##
=======================================
  Coverage   87.31%   87.31%           
=======================================
  Files          90       90           
  Lines        4942     4942           
=======================================
  Hits         4315     4315           
  Misses        464      464           
  Partials      163      163           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f2540...70d333b. Read the comment docs.

@mergify mergify bot requested a review from jpkrohling October 28, 2020 12:41
@mergify mergify bot merged commit fda5695 into jaegertracing:master Oct 28, 2020
@kevinearls kevinearls deleted the fix-when-using-otel-config branch October 28, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants