Remove gRPC host-port from being added to the CR (agent) #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
|
@jkandasa are you able to test this PR? This is the image I published with it: |
|
@rubenvp8510, could you review this one? |
Codecov Report
@@ Coverage Diff @@
## master #1272 +/- ##
==========================================
- Coverage 87.43% 87.42% -0.02%
==========================================
Files 90 90
Lines 4933 4929 -4
==========================================
- Hits 4313 4309 -4
Misses 457 457
Partials 163 163
Continue to review full report at Codecov.
|
|
This looks good to me. I think this is the right approach, relies on sidecar/daemonset to inject the proper gRPC arguments. |
objectiser
approved these changes
Oct 22, 2020
|
codecov is freaking out because less lines are being covered. Apparently, it can't understand that those lines were actually removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1271.
Previously, the upgrade routine for 1.18 was adding the gRPC host-port option to the CR. In fact, the host-port is already being added by the sidecar/daemonset if this options isn't set. The CR should only be set by users, in which case we wouldn't touch it again (not for sidecar/daemonset, not for upgrades).
Signed-off-by: Juraci Paixão Kröhling [email protected]