Add CQLSH_PORT environment variable #1243
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
==========================================
+ Coverage 87.34% 87.36% +0.01%
==========================================
Files 90 90
Lines 4900 4907 +7
==========================================
+ Hits 4280 4287 +7
Misses 457 457
Partials 163 163
Continue to review full report at Codecov.
|
| foundValue := "" | ||
| for _, e := range b[0].Spec.Template.Spec.Containers[0].Env { | ||
| if e.Name == "CQLSH_PORT" { | ||
| foundValue = e.Value |
There was a problem hiding this comment.
Small improvement: you could make an assertion here: assert.Equal(t, "9042", ...) and then return. Where your current assert.Equal is (at the end of the test), you could have a assert.Fail(t, "value for CQLSH_PORT not found")
Ashmita152
force-pushed
the
custom-port
branch
from
d057532 to
f38619c
Compare
| for _, e := range b[0].Spec.Template.Spec.Containers[0].Env { | ||
| if e.Name == "CQLSH_PORT" { | ||
| foundValue := e.Value | ||
| assert.Equal(t, "9042", foundValue, "unexpected CQLSH_PORT environment var value") |
There was a problem hiding this comment.
It's missing the return statement, so that the test is now failing :-) You might also not need the foundValue anymore: you can use e.Value directly in the assertion.
Signed-off-by: Ashmita Bohara <[email protected]>
Ashmita152
force-pushed
the
custom-port
branch
from
48a8240 to
389203b
Compare
|
LGTM. Will be merged on green. Thank you for your contribution! |
|
Thank you for your quick feedbacks @jpkrohling It was my pleasure contributing. |
Signed-off-by: Ashmita Bohara [email protected]
Since jaegertracing/jaeger#2472 is merged, adding support for custom port here.
Partially Fixes: #1179