Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper jaeger-operator version for e2e tests and remove readiness check from DaemonSet #120

Merged

Conversation

jpkrohling
Copy link
Contributor

Signed-off-by: Juraci Paixão Kröhling [email protected]

… check from DaemonSet

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling
Copy link
Contributor Author

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #120 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   92.35%   92.28%   -0.07%     
==========================================
  Files          25       25              
  Lines        1072     1063       -9     
==========================================
- Hits          990      981       -9     
  Misses         82       82
Impacted Files Coverage Δ
pkg/deployment/agent.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee056b7...789b2fc. Read the comment docs.

@jpkrohling
Copy link
Contributor Author

$ make e2e-tests 
Formatting code...
Building...
Sending build context to Docker daemon  76.45MB
Step 1/4 : FROM alpine:3.8
 ---> 196d12cf6ab1
Step 2/4 : USER nobody
 ---> Using cache
 ---> 18305c5b670d
Step 3/4 : ADD build/_output/bin/jaeger-operator /usr/local/bin/jaeger-operator
 ---> c434f7a5f444
Step 4/4 : ENTRYPOINT ["/usr/local/bin/jaeger-operator"]
 ---> Running in 7eb9d4dd84ac
Removing intermediate container 7eb9d4dd84ac
 ---> 268146a7fa55
Successfully built 268146a7fa55
Successfully tagged jpkroehling/jaeger-operator:latest
Pushing image jpkroehling/jaeger-operator:latest...
Running end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	167.020s

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jpkrohling
Copy link
Contributor Author

@dlmiddlecote, this PR removes the readiness check. I thought you might want to get a heads-up on this change.

@jpkrohling jpkrohling merged commit 4d9b695 into jaegertracing:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants