Create service accounts before storage dependencies/init schemas #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
=======================================
Coverage 88.30% 88.30%
=======================================
Files 89 89
Lines 5506 5506
=======================================
Hits 4862 4862
Misses 474 474
Partials 170 170
Continue to review full report at Codecov.
|
jpkrohling
approved these changes
Sep 15, 2020
chgl
pushed a commit
to chgl/jaeger-operator
that referenced
this pull request
Sep 18, 2020
…gertracing#1196) Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #1144 added SA to rollover. However the rollover is also used to init storage schema (dependencies) and the service accounts were created after storage dependencies which was causing errors.
Signed-off-by: Pavol Loffay [email protected]