Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create daemonsets after services and deployments. #1176

Merged
merged 2 commits into from
Sep 7, 2020

Conversation

jpkrohling
Copy link
Contributor

Fixes #1175

Signed-off-by: Juraci Paixão Kröhling [email protected]

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #1176 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
+ Coverage   88.28%   88.30%   +0.01%     
==========================================
  Files          89       89              
  Lines        5498     5506       +8     
==========================================
+ Hits         4854     4862       +8     
  Misses        474      474              
  Partials      170      170              
Impacted Files Coverage Δ
pkg/controller/jaeger/jaeger_controller.go 36.46% <0.00%> (ø)
pkg/apis/jaegertracing/v1/options.go 89.65% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6451f06...2f906d5. Read the comment docs.

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling
Copy link
Contributor Author

@kevinearls if this looks good to you, I'll merge it.

@kevinearls
Copy link
Contributor

@jpkrohling Unfortunately this is still failing for me. It's slightly better, as it passed 6 out of 10 times as opposed to 5 out of 10 previously, but it doesn't seem to be completely resolved.

@jpkrohling
Copy link
Contributor Author

This won't be 100% until the real fix (jaegertracing/jaeger#2443) is in place.

@kevinearls
Copy link
Contributor

@jpkrohling Is that likely to happen soon? If not I can either skip this test or see if I can come up with a retry mechanism of some sort.

@jpkrohling
Copy link
Contributor Author

I'm working on it at the moment, but a release is unlikely to happen during the next couple of weeks.

@jpkrohling jpkrohling merged commit 8be4c6b into jaegertracing:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DaemonSet started before deployment can't get collector IPs
2 participants