Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicitly setting agent's reporter type #1168

Merged

Conversation

pavolloffay
Copy link
Member

Tchannel reporter has been removed in 1.18.0
The GRPC reporter was set as default in 1.11.0

This also helps with using OTEL based images since they do not expose --reporter.type flag.

Tchannel reporter has been removed in 1.18.0
The GRPC reporter was set as default in 1.11.0

Signed-off-by: Pavol Loffay <[email protected]>
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #1168 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1168      +/-   ##
==========================================
- Coverage   88.29%   88.28%   -0.01%     
==========================================
  Files          89       89              
  Lines        5501     5498       -3     
==========================================
- Hits         4857     4854       -3     
  Misses        474      474              
  Partials      170      170              
Impacted Files Coverage Δ
pkg/deployment/agent.go 96.18% <100.00%> (-0.06%) ⬇️
pkg/inject/sidecar.go 94.68% <100.00%> (-0.06%) ⬇️
pkg/storage/cassandra_dependencies.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea13b2...04252be. Read the comment docs.

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this change, but has this flag been deprecated? If not, it would be good to deprecate it now and set a date for removal.

@pavolloffay
Copy link
Member Author

The flag hasn't been deprecated or removed, but there is only one reporter type and no current plans to add another one, hence we can use the default.

@pavolloffay pavolloffay merged commit 78ecb22 into jaegertracing:master Aug 25, 2020
@jpkrohling
Copy link
Contributor

jpkrohling commented Aug 25, 2020

From our operator's perspective, sure. But I mean that other people out there might be using this flag as well. Just removing that without deprecating will break them.

@pavolloffay
Copy link
Member Author

How would it break them? The flag is still supported in Jaeger.

@jpkrohling
Copy link
Contributor

Sorry, my bad. I thought that having this flag would cause an error with the new binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants