Added missing metrics port to operator's deployment #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
=======================================
Coverage 88.26% 88.26%
=======================================
Files 89 89
Lines 5487 5487
=======================================
Hits 4843 4843
Misses 474 474
Partials 170 170 Continue to review full report at Codecov.
|
objectiser
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #1114, I found a small problem in the operator's deployment descriptor, where it's missing one port that is referenced by the service created to back the service monitor.
Also added a target to install the Prometheus Operator.
Signed-off-by: Juraci Paixão Kröhling [email protected]