Set the grpc port name to include http(s) prefix.

[jpkrohling]

Fixes #1117 by setting the gRPC port name to include the https- prefix in case TLS is enabled, and http- if TLS isn't enabled.

Signed-off-by: Juraci Paixão Kröhling [email protected]

[codecov]

Codecov Report

Merging #1122 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
+ Coverage   88.07%   88.09%   +0.02%     
==========================================
  Files          86       86              
  Lines        5283     5294      +11     
==========================================
+ Hits         4653     4664      +11     
  Misses        466      466              
  Partials      164      164              

Impacted Files	Coverage Δ
pkg/service/collector.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f0191...44f2c4c. Read the comment docs.

[objectiser]

Should this ever happen?

[jpkrohling]

Not in the common path, not with the code we have today.

[jpkrohling]

I manually tested this in an OpenShift cluster (crc) with Service Mesh installed and auto-injecting the Istio sidecar, and can confirm that this fixes the reported issue:

$ kubectl logs deployment/myapp -c jaeger-agent -f
2020/07/07 14:17:44 maxprocs: Leaving GOMAXPROCS=6: CPU quota undefined
{"level":"info","ts":1594131464.91614,"caller":"flags/service.go:116","msg":"Mounting metrics handler on admin server","route":"/metrics"}
{"level":"info","ts":1594131464.9164233,"caller":"flags/admin.go:120","msg":"Mounting health check on admin server","route":"/"}
{"level":"info","ts":1594131464.916458,"caller":"flags/admin.go:126","msg":"Starting admin HTTP server","http-addr":":14271"}
{"level":"info","ts":1594131464.9164734,"caller":"flags/admin.go:112","msg":"Admin server started","http.host-port":"[::]:14271","health-status":"unavailable"}
{"level":"warn","ts":1594131464.9164839,"caller":"reporter/flags.go:61","msg":"Using deprecated configuration","option":"jaeger.tags"}
{"level":"info","ts":1594131464.9167476,"caller":"grpc/builder.go:57","msg":"Agent requested secure grpc connection to collector(s)"}
{"level":"info","ts":1594131464.916988,"caller":"[email protected]/clientconn.go:106","msg":"parsed scheme: \"dns\"","system":"grpc","grpc_log":true}
{"level":"info","ts":1594131464.9179482,"caller":"command-line-arguments/main.go:78","msg":"Starting agent"}
{"level":"info","ts":1594131464.9179833,"caller":"healthcheck/handler.go:128","msg":"Health Check state change","status":"ready"}
{"level":"info","ts":1594131464.9180768,"caller":"app/agent.go:69","msg":"Starting jaeger-agent HTTP server","http-port":5778}
{"level":"info","ts":1594131464.9197319,"caller":"dns/dns_resolver.go:212","msg":"ccResolverWrapper: sending update to cc: {[{10.128.0.71:14250  <nil> 0 <nil>}] <nil> <nil>}","system":"grpc","grpc_log":true}
{"level":"info","ts":1594131464.919748,"caller":"[email protected]/clientconn.go:948","msg":"ClientConn switching balancer to \"round_robin\"","system":"grpc","grpc_log":true}
{"level":"warn","ts":1594131464.9200146,"caller":"[email protected]/clientconn.go:1223","msg":"grpc: addrConn.createTransport failed to connect to {10.128.0.71:14250  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 10.128.0.71:14250: connect: connection refused\". Reconnecting...","system":"grpc","grpc_log":true}
{"level":"info","ts":1594131465.921045,"caller":"base/balancer.go:196","msg":"roundrobinPicker: newPicker called with info: {map[]}","system":"grpc","grpc_log":true}
{"level":"warn","ts":1594131465.921427,"caller":"[email protected]/clientconn.go:1223","msg":"grpc: addrConn.createTransport failed to connect to {10.128.0.71:14250  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 10.128.0.71:14250: connect: connection refused\". Reconnecting...","system":"grpc","grpc_log":true}
{"level":"info","ts":1594131467.4787097,"caller":"base/balancer.go:196","msg":"roundrobinPicker: newPicker called with info: {map[]}","system":"grpc","grpc_log":true}
{"level":"info","ts":1594131467.5079808,"caller":"base/balancer.go:196","msg":"roundrobinPicker: newPicker called with info: {map[0xc0002055e0:{{10.128.0.71:14250  <nil> 0 <nil>}}]}","system":"grpc","grpc_log":true}
{"level":"info","ts":1594131494.9264517,"caller":"dns/dns_resolver.go:212","msg":"ccResolverWrapper: sending update to cc: {[{10.128.0.71:14250  <nil> 0 <nil>}] <nil> <nil>}","system":"grpc","grpc_log":true}

And I see traces arriving at the Jaeger backend. Here's a sample of a trace generated based on the business-application-injected-sidecar.yaml: