Deploy trusted CA config map in OpenShift when agent injected into a … #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…different namespace than the jaeger instance Signed-off-by: Gary Brown <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1110 +/- ##
==========================================
+ Coverage 88.00% 88.02% +0.02%
==========================================
Files 86 86
Lines 5254 5263 +9
==========================================
+ Hits 4624 4633 +9
Misses 466 466
Partials 164 164
Continue to review full report at Codecov.
|
jpkrohling
reviewed
Jul 2, 2020
| @@ -124,6 +125,25 @@ func (r *ReconcileDeployment) Reconcile(request reconcile.Request) (reconcile.Re | |||
|
|
|||
| jaeger := inject.Select(dep, ns, jaegers) | |||
| if jaeger != nil && jaeger.GetDeletionTimestamp() == nil { | |||
| if jaeger.Namespace != request.Namespace { | |||
| log.WithFields(log.Fields{ | |||
| "jaeger namespace": jaeger.Namespace, | |||
There was a problem hiding this comment.
For someone grepping the logs, it might be better to have jaeger-namespace or jaeger.namespace than jaeger namespace.
| log.WithFields(log.Fields{ | ||
| "jaeger namespace": jaeger.Namespace, | ||
| "app namespace": request.Namespace, | ||
| }).Info("different namespaces, so check whether trusted CA bundle configmap should be created") |
Signed-off-by: Gary Brown <[email protected]>
Signed-off-by: Gary Brown <[email protected]>
|
@jpkrohling Updated - don't think the otel-es test TestElasticSearchSuite/TestSparkDependenciesES is anything related to this PR. |
jpkrohling
approved these changes
Jul 3, 2020
jpkrohling
pushed a commit
to jpkrohling/jaeger-operator
that referenced
this pull request
Dec 15, 2020
…gertracing#1110) Deploy trusted CA config map in OpenShift when agent injected into a different namespace than the jaeger instance Signed-off-by: Gary Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…different namespace than the jaeger instance
Resolves #1092
Signed-off-by: Gary Brown [email protected]