Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation cannot be fulfilled on deployments.apps... #927

Closed
jpkrohling opened this issue Feb 26, 2020 · 8 comments
Closed

Operation cannot be fulfilled on deployments.apps... #927

jpkrohling opened this issue Feb 26, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@jpkrohling
Copy link
Contributor

While testing #914, I saw a message similar to the following in the logs. Trying it out with the latest master confirms that this exists there as well:

ERRO[0071] failed to update                              deployment="&Deployment{ObjectMeta:{myapp  default /apis/apps/v1/namespaces/default/deployments/myapp a86b37e2-2b22-4723-9327-6fb8cdfdc458 286277 1 2020-02-26 10:27:50 +0100 CET <nil> <nil> map[sidecar.jaegertracing.io/injected:simple-prod] map[kubectl.kubernetes.io/last-applied-configuration:{\"apiVersion\":\"apps/v1\",\"kind\":\"Deployment\",\"metadata\":{\"annotations\":{\"sidecar.jaegertracing.io/inject\":\"true\"},\"name\":\"myapp\",\"namespace\":\"default\"},\"spec\":{\"selector\":{\"matchLabels\":{\"app\":\"myapp\"}},\"template\":{\"metadata\":{\"annotations\":{\"sidecar.istio.io/inject\":\"true\"},\"labels\":{\"app\":\"myapp\"}},\"spec\":{\"containers\":[{\"image\":\"jaegertracing/vertx-create-span:operator-e2e-tests\",\"name\":\"myapp\",\"ports\":[{\"containerPort\":8080,\"protocol\":\"TCP\"}]}]}}}}\n prometheus.io/port:5778 prometheus.io/scrape:true sidecar.jaegertracing.io/inject:simple-prod] [] []  []},Spec:DeploymentSpec{Replicas:*1,Selector:&v1.LabelSelector{MatchLabels:map[string]string{app: myapp,},MatchExpressions:[]LabelSelectorRequirement{},},Template:{{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[app:myapp] map[sidecar.istio.io/inject:true] [] []  []} {[] [] [{myapp jaegertracing/vertx-create-span:operator-e2e-tests [] []  [{ 0 8080 TCP }] [] [{JAEGER_SERVICE_NAME myapp.default nil} {JAEGER_PROPAGATION jaeger,b3 nil}] {map[] map[]} [] [] nil nil nil nil /dev/termination-log File IfNotPresent nil false false false} {jaeger-agent jaegertracing/jaeger-agent:1.16.0 [] [--jaeger.tags=cluster=undefined,deployment.name=myapp,pod.namespace=default,pod.name=${POD_NAME:},host.ip=${HOST_IP:},container.name=myapp --reporter.grpc.host-port=dns:///simple-prod-collector-headless.default:14250 --reporter.type=grpc]  [{zk-compact-trft 0 5775 UDP } {config-rest 0 5778  } {jg-compact-trft 0 6831 UDP } {jg-binary-trft 0 6832 UDP }] [] [{POD_NAME  EnvVarSource{FieldRef:&ObjectFieldSelector{APIVersion:,FieldPath:metadata.name,},ResourceFieldRef:nil,ConfigMapKeyRef:nil,SecretKeyRef:nil,}} {HOST_IP  &EnvVarSource{FieldRef:&ObjectFieldSelector{APIVersion:,FieldPath:status.hostIP,},ResourceFieldRef:nil,ConfigMapKeyRef:nil,SecretKeyRef:nil,}}] {map[] map[]} [] [] nil nil nil nil    nil false false false}] [] Always 0xc0011e6a80 <nil> ClusterFirst map[]   <nil>  false false false <nil> &PodSecurityContext{SELinuxOptions:nil,RunAsUser:nil,RunAsNonRoot:nil,SupplementalGroups:[],FSGroup:nil,RunAsGroup:nil,Sysctls:[]Sysctl{},WindowsOptions:nil,} []   nil default-scheduler [] []  <nil> nil [] <nil> <nil> <nil> map[] []}},Strategy:DeploymentStrategy{Type:RollingUpdate,RollingUpdate:&RollingUpdateDeployment{MaxUnavailable:25%,MaxSurge:25%,},},MinReadySeconds:0,RevisionHistoryLimit:*10,Paused:false,ProgressDeadlineSeconds:*600,},Status:DeploymentStatus{ObservedGeneration:0,Replicas:0,UpdatedReplicas:0,AvailableReplicas:0,UnavailableReplicas:0,Conditions:[]DeploymentCondition{},ReadyReplicas:0,CollisionCount:nil,},}" error="Operation cannot be fulfilled on deployments.apps \"myapp\": the object has been modified; please apply your changes to the latest version and try again"

This can be reproduced by deploying our example deploy/examples/business-application-injected-sidecar.yaml:

apiVersion: apps/v1
kind: Deployment
metadata:
name: myapp
annotations:
"sidecar.jaegertracing.io/inject": "true"
spec:
selector:
matchLabels:
app: myapp
template:
metadata:
labels:
app: myapp
annotations:
sidecar.istio.io/inject: "true"
spec:
containers:
- name: myapp
image: jaegertracing/vertx-create-span:operator-e2e-tests
ports:
- containerPort: 8080
protocol: TCP

@rubenvp8510 would you be able to look into this one?

@jpkrohling jpkrohling added the bug Something isn't working label Feb 26, 2020
@ghost ghost added the needs-triage New issues, in need of classification label Feb 26, 2020
@rubenvp8510
Copy link
Collaborator

Yes, I'll take a look.

@jpkrohling jpkrohling removed the needs-triage New issues, in need of classification label Mar 9, 2020
@rubenvp8510
Copy link
Collaborator

@jpkrohling is this still an issue? Or was fixed via #940 ?

@jpkrohling
Copy link
Contributor Author

I believe this was fixed.

@SS30723
Copy link

SS30723 commented Aug 22, 2020

Hi, I am still getting this error 'Operation cannot be fulfilled on deployments.apps'. I have used auto side car injection as given in the example, deploy/examples/business-application-injected-sidecar.yaml.
I see the UI is up and running and I am able to view jaeger-query service, but the calls related to my app is not coming up on the UI. Is it because of the above error?

@172prateek
Copy link

172prateek commented Nov 13, 2021

@SS30723 I am also facing same issue... and doing exactly same what you have done. have you got nay resolution in it..

@jpkrohling I am also getting below error while deploying sample application (business-application-injected-sidecar.yaml) . I am able to view jaeger-query service in UI. but this service is not appearing in UI..

This is what I have got in operator log. however I could see 2/2 container running in sample application pod. But the service is not appearing in jaeger UI

error msg="failed to update deployment with sidecar" error="Operation cannot be fulfilled on deployments.apps "myapp": the object has been modified; please apply your changes to the latest version and try again" jaeger=jaeger-kafka-poc jaeger-namespace=observability name=myapp namespace=observability

@Andycharalambous
Copy link

Having same problem - jaeger-operator v1.28.0. Upgraded yesterday to fix a few other bugs we had with correct collector selection in sidecar injector. Now none of our deployments get injected with latest version of jaeger-agent.

@purvaldur
Copy link

purvaldur commented Mar 23, 2022

Also having the same problem after an upgrade to v1.27.0 to fix another bug. I've temporarily degraded back to 1.24 since the error I'm getting on 1.24 is non-blocking at the moment. The issue might be related to: #1644 or #1648 ?

@violinorg
Copy link

Having same problem - jaeger-operator v1.36.0. Yesterday was updated along with the cluster components. Previously on v1.35.0 there were no problems. Reverting the version didn't fix the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants