Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecar injection failures #1648

Closed
jpkrohling opened this issue Dec 2, 2021 · 18 comments
Closed

Sidecar injection failures #1648

jpkrohling opened this issue Dec 2, 2021 · 18 comments
Labels
bug Something isn't working

Comments

@jpkrohling
Copy link
Contributor

When installing the simple-prod example in the monitoring namespace, the following is shown in the logs:

INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
ERRO[1123] failed to update deployment with sidecar      error="Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
2021-12-02T11:29:03.810+0100	ERROR	controller-runtime.manager.controller.deployment	Reconciler error	{"reconciler group": "apps", "reconciler kind": "Deployment", "name": "simple-prod-query", "namespace": "monitoring", "error": "Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214
INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
ERRO[1123] failed to update deployment with sidecar      error="Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
2021-12-02T11:29:03.868+0100	ERROR	controller-runtime.manager.controller.deployment	Reconciler error	{"reconciler group": "apps", "reconciler kind": "Deployment", "name": "simple-prod-query", "namespace": "monitoring", "error": "Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214
INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
ERRO[1123] failed to update deployment with sidecar      error="Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
2021-12-02T11:29:03.900+0100	ERROR	controller-runtime.manager.controller.deployment	Reconciler error	{"reconciler group": "apps", "reconciler kind": "Deployment", "name": "simple-prod-query", "namespace": "monitoring", "error": "Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214
INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
ERRO[1123] failed to update deployment with sidecar      error="Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
2021-12-02T11:29:03.918+0100	ERROR	controller-runtime.manager.controller.deployment	Reconciler error	{"reconciler group": "apps", "reconciler kind": "Deployment", "name": "simple-prod-query", "namespace": "monitoring", "error": "Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214
INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
ERRO[1123] failed to update deployment with sidecar      error="Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
2021-12-02T11:29:03.970+0100	ERROR	controller-runtime.manager.controller.deployment	Reconciler error	{"reconciler group": "apps", "reconciler kind": "Deployment", "name": "simple-prod-query", "namespace": "monitoring", "error": "Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214
INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
ERRO[1123] failed to update deployment with sidecar      error="Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
2021-12-02T11:29:03.993+0100	ERROR	controller-runtime.manager.controller.deployment	Reconciler error	{"reconciler group": "apps", "reconciler kind": "Deployment", "name": "simple-prod-query", "namespace": "monitoring", "error": "Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214
INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1123] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
ERRO[1123] failed to update deployment with sidecar      error="Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
2021-12-02T11:29:04.018+0100	ERROR	controller-runtime.manager.controller.deployment	Reconciler error	{"reconciler group": "apps", "reconciler kind": "Deployment", "name": "simple-prod-query", "namespace": "monitoring", "error": "Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214
INFO[1124] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1124] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1147] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
ERRO[1148] failed to update deployment with sidecar      error="Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
2021-12-02T11:29:28.058+0100	ERROR	controller-runtime.manager.controller.deployment	Reconciler error	{"reconciler group": "apps", "reconciler kind": "Deployment", "name": "simple-prod-query", "namespace": "monitoring", "error": "Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214
INFO[1148] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
ERRO[1148] failed to update deployment with sidecar      error="Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
2021-12-02T11:29:28.084+0100	ERROR	controller-runtime.manager.controller.deployment	Reconciler error	{"reconciler group": "apps", "reconciler kind": "Deployment", "name": "simple-prod-query", "namespace": "monitoring", "error": "Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214
INFO[1148] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1148] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
ERRO[1148] failed to update deployment with sidecar      error="Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
2021-12-02T11:29:28.105+0100	ERROR	controller-runtime.manager.controller.deployment	Reconciler error	{"reconciler group": "apps", "reconciler kind": "Deployment", "name": "simple-prod-query", "namespace": "monitoring", "error": "Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214
INFO[1148] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
ERRO[1148] failed to update deployment with sidecar      error="Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
2021-12-02T11:29:28.120+0100	ERROR	controller-runtime.manager.controller.deployment	Reconciler error	{"reconciler group": "apps", "reconciler kind": "Deployment", "name": "simple-prod-query", "namespace": "monitoring", "error": "Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214
INFO[1148] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1148] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1148] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1150] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
ERRO[1150] failed to update deployment with sidecar      error="Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
2021-12-02T11:29:30.589+0100	ERROR	controller-runtime.manager.controller.deployment	Reconciler error	{"reconciler group": "apps", "reconciler kind": "Deployment", "name": "simple-prod-query", "namespace": "monitoring", "error": "Operation cannot be fulfilled on deployments.apps \"simple-prod-query\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/home/jpkroehling/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214
INFO[1150] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1150] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1157] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
INFO[1157] injecting Jaeger Agent sidecar                jaeger=simple-prod jaeger-namespace=monitoring name=simple-prod-query namespace=monitoring
@jpkrohling jpkrohling added the bug Something isn't working label Dec 2, 2021
@rubenvp8510
Copy link
Collaborator

Which version are you using? 1.28.0? or is this with master?

@jpkrohling
Copy link
Contributor Author

Latest master as of now (e0c53a5)

@rubenvp8510
Copy link
Collaborator

I was debugging this issue, and it seems like this happens because we changed the way we auto instrumented the query deployment, when the deployment is starting it mutates its state, and when we try to update the deployment with the sidecar, it throws this kind of errors. I saw this before in other injection scenarios as well.

I can get the object one more time before the update to make sure I have the latest version, but I find this problematic and hard to solve. I think the only definitive solution will be to use webhook mutator.

@QLeelulu
Copy link

same error in 1.29.0

time="2022-01-11T07:08:37Z" level=info msg="injecting Jaeger Agent sidecar" jaeger=jaeger jaeger-namespace=observability name=jaeger-query namespace=observability

time="2022-01-11T07:08:37Z" level=error msg="failed to update deployment with sidecar" error="Operation cannot be fulfilled on deployments.apps \"jaeger-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=jaeger jaeger-namespace=observability name=jaeger-query namespace=observability

2022-01-11T07:08:37.655Z ERROR controller-runtime.manager.controller.deployment Reconciler error {"reconciler group": "apps", "reconciler kind": "Deployment", "name": "jaeger-query", "namespace": "observability", "error": "Operation cannot be fulfilled on deployments.apps \"jaeger-query\": the object has been modified; please apply your changes to the latest version and try again"}

sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem

/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253

sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2

/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214

time="2022-01-11T07:08:38Z" level=info msg="injecting Jaeger Agent sidecar" jaeger=jaeger jaeger-namespace=observability name=jaeger-query namespace=observability

time="2022-01-11T07:08:38Z" level=error msg="failed to update deployment with sidecar" error="Operation cannot be fulfilled on deployments.apps \"jaeger-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=jaeger jaeger-namespace=observability name=jaeger-query namespace=observability

2022-01-11T07:08:38.082Z ERROR controller-runtime.manager.controller.deployment Reconciler error {"reconciler group": "apps", "reconciler kind": "Deployment", "name": "jaeger-query", "namespace": "observability", "error": "Operation cannot be fulfilled on deployments.apps \"jaeger-query\": the object has been modified; please apply your changes to the latest version and try again"}

@diogoserrano
Copy link

after upgrading jaeger-operator from 1.29 to 1.32 i get the same error

time="2022-03-22T10:24:07Z" level=error msg="failed to update deployment with sidecar" error="Operation cannot be fulfilled on deployments.apps \"general-query\": the object has been modified; please apply your changes to the latest version and try again" jaeger=general jaeger-namespace=jaeger name=general-query namespace=jaeger 2022-03-22T10:24:07.740Z ERROR controller-runtime.manager.controller.deployment Reconciler error {"reconciler group": "apps", "reconciler kind": "Deployment", "name": "general-query", "namespace": "jaeger", "error": "Operation cannot be fulfilled on deployments.apps \"general-query\": the object has been modified; please apply your changes to the latest version and try again"} sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2 /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214 time="2022-03-22T10:24:07Z" level=info msg="injecting Jaeger Agent sidecar" jaeger=general jaeger-namespace=jaeger name=general-query namespace=jaeger time="2022-03-22T10:24:08Z" level=info msg="injecting Jaeger Agent sidecar" jaeger=general jaeger-namespace=jaeger name=general-query namespace=jaeger

@arushi09-hub
Copy link

I am also having the same error. I am using the very latest version of Jaeger-operator which is 1.34. Error which i am getting looks like

msg="Operation cannot be fulfilled on deployments.apps "myapp": the object has been modified; please apply your changes to the latest version and try again" component=jaeger-cr-sync
1.6532994235610714e+09 ERROR controller.jaeger Reconciler error {"reconciler group": "jaegertracing.io", "reconciler kind": "Jaeger", "name": "jaeger", "namespace": "observability", "error": "Operation cannot be fulfilled on deployments.apps "myapp": the object has been modified; please apply your changes to the latest version and try again"

Any suggestions what should i do?

@arushi09-hub
Copy link

I was debugging this issue, and it seems like this happens because we changed the way we auto instrumented the query deployment, when the deployment is starting it mutates its state, and when we try to update the deployment with the sidecar, it throws this kind of errors. I saw this before in other injection scenarios as well.

I can get the object one more time before the update to make sure I have the latest version, but I find this problematic and hard to solve. I think the only definitive solution will be to use webhook mutator.

How will a webhook mutator be used here? I think I am not aware of it, of how it will be used.

@frzifus
Copy link
Member

frzifus commented May 24, 2022

Does the error message show an effect? My guess is, when a deployment is created, it passes through the provided webhook to modify the pod spec.
if now a Jaeger instance is created, updated or removed in parallel, the reconciler notices that this deployment needs an update. To realize this update the deployment specification is extended with an annotation. The error message appears because the webhook has already modified the deployment spec.
Since we return an error in the reconciler, the deployment is evaluated again shortly afterwards.

@frzifus
Copy link
Member

frzifus commented May 24, 2022

Probably we can ignore this error and simply trigger the Jaeger reconciler again to be on the safe side.

@arushi09-hub
Copy link

Probably we can ignore this error and simply trigger the Jaeger reconciler again to be on the safe side.

What command can I use to trigger the reconciler again?

@arushi09-hub
Copy link

Does the error message show an effect? My guess is, when a deployment is created, it passes through the provided webhook to modify the pod spec. if now a Jaeger instance is created, updated or removed in parallel, the reconciler notices that this deployment needs an update. To realize this update the deployment specification is extended with an annotation. The error message appears because the webhook has already modified the deployment spec. Since we return an error in the reconciler, the deployment is evaluated again shortly afterwards.

I am unable to see this service on my Jaeger UI which is properly up and running and shows the jaegery-query service also. The pods were perfectly running still i could not see it on the UI. Went through the logs of jaeger-operator and saw this error over here. Assumed that it can be because this error.

@frzifus
Copy link
Member

frzifus commented May 24, 2022

What command can I use to trigger the reconciler again?

Its done automatically. No action need.

I am unable to see this service on my Jaeger UI which is properly up and running and shows the jaegery-query service also. The pods were perfectly running still i could not see it on the UI. Went through the logs of jaeger-operator and saw this error over here. Assumed that it can be because this error.

I assume there is no correlation. But i will look into it.

@violinorg
Copy link

Having same problem - jaeger-operator v1.36.0. Yesterday was updated along with the cluster components. Previously on v1.35.0 there were no problems. Reverting the version didn't fix the problem

@iblancasa
Copy link
Collaborator

@violinorg, could you provide some log output?

@frzifus
Copy link
Member

frzifus commented Aug 25, 2022

Probably the log output is similar to the other reports. Looks like the logging is causing confusion, maybe we should change the reported message and/or only log on debug level.

What do you think?

@iblancasa
Copy link
Collaborator

If it is not raising a real issue...

@violinorg
Copy link

@iblancasa yes of course

time="2022-08-26T12:40:04Z" level=error msg="Operation cannot be fulfilled on deployments.apps \"r882-dcc95-observability-tracing-demo\": the object has been modified; please apply your changes to the latest version an │
│ 1.6615176046172814e+09    ERROR    Reconciler error    {"controller": "jaeger", "controllerGroup": "jaegertracing.io", "controllerKind": "Jaeger", "jaeger": {"name":"observability-t1260-3f32c-jaeger-operator-jaeger","n │
│ sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem                                                                                                                                   │
│     /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:273

@iblancasa
Copy link
Collaborator

@frzifus I'm not sure but it seems this message is not printed by Jaeger Operator but by the inherit logger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants