Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JaegerIngressSpec for all-in-one #48

Closed
jpkrohling opened this issue Oct 4, 2018 · 3 comments
Closed

Add support for JaegerIngressSpec for all-in-one #48

jpkrohling opened this issue Oct 4, 2018 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@jpkrohling
Copy link
Contributor

The JaegerIngressSpec was introduced as part of #30, but the all-in-one missed this, as pointed out by @sneko on that issue

I left a comment there as well, with what would need to be changed to get it fixed. A unit test similar to the one from the query is also required to complete this task.

https://github.com/jaegertracing/jaeger-operator/blob/master/pkg/deployment/query_test.go#L64-L100

@jpkrohling
Copy link
Contributor Author

This is how the configuration should look like for the all-in-one:

spec:
  strategy: all-in-one
  all-in-one:
    ingress:
      enabled: false

@jpkrohling
Copy link
Contributor Author

Thanks for the PR, @secat! I'll leave this open, as I think we are missing some documentation about this feature, both in the readme and in the example files.

@jpkrohling
Copy link
Contributor Author

jpkrohling commented Oct 4, 2018

I think the PR might actually not work -- the current NewQueryIngress method is backed by a query service named "%s-query", jaeger.Name, which might not be appropriate for the all-in-one. Scratch that -- let me test before I make wild speculations :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant