You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The JaegerIngressSpec was introduced as part of #30, but the all-in-one missed this, as pointed out by @sneko on that issue
I left a comment there as well, with what would need to be changed to get it fixed. A unit test similar to the one from the query is also required to complete this task.
Thanks for the PR, @secat! I'll leave this open, as I think we are missing some documentation about this feature, both in the readme and in the example files.
I think the PR might actually not work -- the current NewQueryIngress method is backed by a query service named "%s-query", jaeger.Name, which might not be appropriate for the all-in-one. Scratch that -- let me test before I make wild speculations :)
The
JaegerIngressSpec
was introduced as part of #30, but the all-in-one missed this, as pointed out by @sneko on that issueI left a comment there as well, with what would need to be changed to get it fixed. A unit test similar to the one from the query is also required to complete this task.
https://github.com/jaegertracing/jaeger-operator/blob/master/pkg/deployment/query_test.go#L64-L100
The text was updated successfully, but these errors were encountered: