Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support repetitive arguments to operand #1415

Closed
jkandasa opened this issue Mar 18, 2021 · 1 comment · Fixed by #1434
Closed

support repetitive arguments to operand #1415

jkandasa opened this issue Mar 18, 2021 · 1 comment · Fixed by #1434
Assignees
Labels
bug Something isn't working

Comments

@jkandasa
Copy link
Member

For now, there is no way to supply repetitive arguments options to the operand

I am expecting the following arguments to query pod, how to specify this in jaeger CR?

--query.additional-headers=access-control-allow-origin:blerg
--query.additional-headers=whatever:thing
spec:
  query:
    options:
      query:
         additional-headers: "whatever:thing"

AFAIK, in YAML we cannot supply the same key multiple times
https://github.com/jaegertracing/jaeger-operator/blob/v1.21.3/pkg/apis/jaegertracing/v1/options.go#L96~L99

@github-actions github-actions bot added the needs-triage New issues, in need of classification label Mar 18, 2021
@jpkrohling jpkrohling added bug Something isn't working and removed needs-triage New issues, in need of classification labels Mar 22, 2021
@rubenvp8510 rubenvp8510 self-assigned this Mar 24, 2021
@rubenvp8510
Copy link
Collaborator

rubenvp8510 commented Mar 24, 2021

i think something like this could be an option:

...
spec:
  query:
    options:
      query:
         additional-headers:
              -  "whatever:thing"
              -  "access-control-allow-origin:blerg"

If that is ok, I can work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants