remove error parameter in getBusinessAppCR

Signed-off-by: Megrez Lu <[email protected]>
jaegertracing · Jan 22, 2021 · 6e7c287 · 6e7c287
1 parent 5854c80
commit 6e7c287
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/test/e2e/examples1_test.go b/test/e2e/examples1_test.go
@@ -104,7 +104,7 @@ func (suite *ExamplesTestSuite) TestBusinessApp() {
 	require.NoError(t, err)
 
 	// Now deploy examples/business-application-injected-sidecar.yaml
-	businessAppCR := getBusinessAppCR(err)
+	businessAppCR := getBusinessAppCR()
 	defer os.Remove(businessAppCR.Name())
 	cmd := exec.Command("kubectl", "create", "--namespace", namespace, "--filename", businessAppCR.Name())
 	output, err := cmd.CombinedOutput()

diff --git a/test/e2e/istio_test.go b/test/e2e/istio_test.go
@@ -85,7 +85,7 @@ func (suite *IstioTestSuite) TestEnvoySidecar() {
 	require.NoError(t, err)
 
 	// Now deploy examples/business-application-injected-sidecar.yaml
-	businessAppCR := getBusinessAppCR(err)
+	businessAppCR := getBusinessAppCR()
 	defer os.Remove(businessAppCR.Name())
 	cmd := exec.Command("kubectl", "create", "--namespace", namespace, "--filename", businessAppCR.Name())
 	output, err := cmd.CombinedOutput()

diff --git a/test/e2e/utils.go b/test/e2e/utils.go
@@ -890,7 +890,7 @@ func waitForDeploymentAndUpdate(deploymentName, containerName string, update fun
 	})
 }
 
-func getBusinessAppCR(err error) *os.File {
+func getBusinessAppCR() *os.File {
 	content, err := ioutil.ReadFile("../../examples/business-application-injected-sidecar.yaml")
 	require.NoError(t, err)
 	newContent := strings.Replace(string(content), "image: jaegertracing/vertx-create-span:operator-e2e-tests", "image: "+vertxExampleImage, 1)