Skip to content

Commit

Permalink
Join multiple E2E test suites in one (#1783)
Browse files Browse the repository at this point in the history
* Join multiple E2E test suites in one

Signed-off-by: Israel Blancas <[email protected]>

* Templatize the name of the concurrency groups

Signed-off-by: Israel Blancas <[email protected]>

* Fix Makefile rule

Signed-off-by: Israel Blancas <[email protected]>

Co-authored-by: Ruben Vargas <[email protected]>
  • Loading branch information
Israel Blancas and rubenvp8510 authored Apr 6, 2022
1 parent 0e2e84d commit 431038e
Show file tree
Hide file tree
Showing 34 changed files with 34 additions and 150 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e-allinone.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
- '**.md'

concurrency:
group: e2e-tests-${{ github.ref }}-allinone
group: e2e-tests-${{ github.ref }}-${{ github.workflow }}
cancel-in-progress: true

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-elasticsearch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
- '**.md'

concurrency:
group: e2e-tests-${{ github.ref }}-elasticsearch
group: e2e-tests-${{ github.ref }}-${{ github.workflow }}
cancel-in-progress: true

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-examples.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
- '**.md'

concurrency:
group: e2e-tests-${{ github.ref }}-examples
group: e2e-tests-${{ github.ref }}-${{ github.workflow }}
cancel-in-progress: true

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-generate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
- '**.md'

concurrency:
group: e2e-tests-${{ github.ref }}-generate
group: e2e-tests-${{ github.ref }}-${{ github.workflow }}
cancel-in-progress: true

jobs:
Expand Down
34 changes: 0 additions & 34 deletions .github/workflows/e2e-istio.yaml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Cassandra E2E tests
name: Miscellaneous E2E tests

on:
push:
Expand All @@ -11,24 +11,24 @@ on:
- '**.md'

concurrency:
group: e2e-tests-${{ github.ref }}-cassandra
group: e2e-tests-${{ github.ref }}-${{ github.workflow }}
cancel-in-progress: true

jobs:
run-e2e-cassandra-test-suite:
run-e2e-miscellaneous-test-suite:
runs-on: ubuntu-20.04
strategy:
matrix:
kube-version:
- "1.19"
- "1.23"
name: Run Cassandra E2E tests
name: Run miscellaneous E2E tests
steps:
- name: "Check out code into the Go module directory"
uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: ./hack/actions/e2e
with:
testsuite_name: cassandra
testsuite_name: miscellaneous
kube_version: ${{ matrix.kube-version }}
34 changes: 0 additions & 34 deletions .github/workflows/e2e-outside-cluster.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/e2e-sidecar.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
- '**.md'

concurrency:
group: e2e-tests-${{ github.ref }}-sidecar
group: e2e-tests-${{ github.ref }}-${{ github.workflow }}
cancel-in-progress: true

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-streaming.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
- '**.md'

concurrency:
group: e2e-tests-${{ github.ref }}-streaming
group: e2e-tests-${{ github.ref }}-${{ github.workflow }}
cancel-in-progress: true

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-upgrade.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
- '**.md'

concurrency:
group: e2e-tests-${{ github.ref }}-upgrade
group: e2e-tests-${{ github.ref }}-${{ github.workflow }}
cancel-in-progress: true

jobs:
Expand Down
5 changes: 0 additions & 5 deletions tests/e2e/cassandra/Makefile

This file was deleted.

15 changes: 0 additions & 15 deletions tests/e2e/cassandra/cassandra-smoke/02-assert.yaml

This file was deleted.

26 changes: 0 additions & 26 deletions tests/e2e/cassandra/render.sh

This file was deleted.

1 change: 0 additions & 1 deletion tests/e2e/istio/.gitignore

This file was deleted.

5 changes: 0 additions & 5 deletions tests/e2e/istio/Makefile

This file was deleted.

3 changes: 0 additions & 3 deletions tests/e2e/istio/istio/.gitignore

This file was deleted.

5 changes: 5 additions & 0 deletions tests/e2e/miscellaneous/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
render-e2e-tests-miscellaneous: set-assert-e2e-img-name load-assert-job
SKIP_ES_EXTERNAL=$(SKIP_ES_EXTERNAL) ./tests/e2e/miscellaneous/render.sh

run-e2e-tests-miscellaneous: TEST_SUITE_NAME=miscellaneous
run-e2e-tests-miscellaneous: run-suite-tests
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
17 changes: 17 additions & 0 deletions tests/e2e/istio/render.sh → tests/e2e/miscellaneous/render.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,16 @@

source $(dirname "$0")/../render-utils.sh

start_test "cassandra-spark"
# Create Cassandra instance and assert it
render_install_cassandra "00"
# Create the Jaeger instance
export JAEGER_NAME=test-spark-deps
export DEP_SCHEDULE=true
export CASSANDRA_MODE=prod
$GOMPLATE -f $TEMPLATES_DIR/cassandra-jaeger-install.yaml.template -o ./01-install.yaml


if [ $IS_OPENSHIFT = true ]; then
skip_test "istio" "Test not supported in OpenShift"
else
Expand All @@ -23,3 +33,10 @@ else
$YQ e -i '.spec.template.spec.containers[0].command = ["/bin/sh","-c"]' $patched_file
$YQ e -i '.spec.template.spec.containers[0].args= ["./query && curl -sf -XPOST http://localhost:15000/quitquitquit"]' $patched_file
fi


start_test "outside-cluster"
jaeger_name="my-jaeger"
render_install_elasticsearch "00"
render_install_jaeger "$jaeger_name" "production" "01"
$GOMPLATE -f ./03-check-collector.yaml.template -o 03-check-collector.yaml
1 change: 0 additions & 1 deletion tests/e2e/outside-cluster/.gitignore

This file was deleted.

5 changes: 0 additions & 5 deletions tests/e2e/outside-cluster/Makefile

This file was deleted.

9 changes: 0 additions & 9 deletions tests/e2e/outside-cluster/render.sh

This file was deleted.

0 comments on commit 431038e

Please sign in to comment.