updated jaeger spec strategy to use constant instead of string

Signed-off-by: Shubhanshu Surana <[email protected]> Signed-off-by: Shubhanshu Surana <[email protected]>
jaegertracing · Nov 4, 2019 · 2785eef · 2785eef
1 parent 1ac060d
commit 2785eef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/config/sampling/sampling.go b/pkg/config/sampling/sampling.go
@@ -88,7 +88,7 @@ func CheckForSamplingConfigFile(jaeger *v1.Jaeger) bool {
 	options := v1.Options{}
 
 	// check for deployment strategy
-	if jaeger.Spec.Strategy == "allInOne" {
+	if jaeger.Spec.Strategy == v1.DeploymentStrategyAllInOne {
 		options = jaeger.Spec.AllInOne.Options
 	} else {
 		options = jaeger.Spec.Collector.Options

diff --git a/pkg/config/sampling/sampling_test.go b/pkg/config/sampling/sampling_test.go
@@ -83,7 +83,7 @@ func TestUpdateWithSamplingConfig(t *testing.T) {
 
 func TestUpdateWithSamplingConfigFileOption(t *testing.T) {
 	jaeger := v1.NewJaeger(types.NamespacedName{Name: "TestUpdateWithSamplingConfigFileOption"})
-	jaeger.Spec.Strategy = "allInOne"
+	jaeger.Spec.Strategy = v1.DeploymentStrategyAllInOne
 	jaeger.Spec.AllInOne.Options = v1.NewOptions(map[string]interface{}{
 		"sampling.strategies-file": "/etc/jaeger/sampling.json",
 	})