Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

Cache nsenster directory on travis #79

Merged
merged 3 commits into from
Mar 23, 2018

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay [email protected]

Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay pavolloffay requested a review from jpkrohling March 22, 2018 10:53
@pavolloffay
Copy link
Member Author

Cheap way to speed up builds

mkdir .tmp || true
wget https://www.kernel.org/pub/linux/utils/util-linux/v2.30/util-linux-2.30.2.tar.gz -qO - | tar -xz -C .tmp/
cd .tmp/util-linux-2.30.2 && ./autogen.sh && ./configure && make nsenter
mkdir $HOME/nsenter || true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use -p instead of || true:

$ mkdir $HOME
mkdir: cannot create directory ‘/home/jpkroehling’: File exists
$ mkdir -p $HOME
$ echo $?
0

wget https://www.kernel.org/pub/linux/utils/util-linux/v2.30/util-linux-2.30.2.tar.gz -qO - | tar -xz -C .tmp/
cd .tmp/util-linux-2.30.2 && ./autogen.sh && ./configure && make nsenter
mkdir $HOME/nsenter || true
if [ ! -d $HOME/nsenster/util-linux-2.30.2 ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to externalize the version into a var? Otherwise, updating the version will be a PITA :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will keep this one as the version is also used in travis.yml and here it has two forms :/

Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay pavolloffay merged commit 90a118e into jaegertracing:master Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants