Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

Do not merge! #77

Closed
wants to merge 2 commits into from
Closed

Do not merge! #77

wants to merge 2 commits into from

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Mar 22, 2018

Shows how to fix CI for #75

diff --git a/jaeger-production-template.yml b/jaeger-production-template.yml
index a6d1ea6..ec620ae 100644
--- a/jaeger-production-template.yml
+++ b/jaeger-production-template.yml
@@ -15,7 +15,7 @@
 apiVersion: v1
 kind: List
 items:
-- apiVersion: apps/v1
+- apiVersion: extensions/v1beta1
   kind: Deployment
   metadata:
     name: jaeger-collector
@@ -103,7 +103,7 @@ items:
     selector:
       jaeger-infra: collector-pod
     type: ClusterIP
-- apiVersion: apps/v1
+- apiVersion: extensions/v1beta1
   kind: Deployment
   metadata:
     name: jaeger-query
@@ -169,7 +169,7 @@ items:
     selector:
       jaeger-infra: query-pod
     type: LoadBalancer
-- apiVersion: apps/v1
+- apiVersion: extensions/v1beta1
   kind: DaemonSet
   metadata:
     name: jaeger-agent

@jpkrohling
Copy link
Collaborator

Does this mean that the testing framework is outdated? "apps/v1" is what the documentation for DaemonSet uses:
https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/

@pavolloffay
Copy link
Member Author

Probably, I don't know how recent is this change. will our resources work on older k8s version if we use apps/v1 ?

@pavolloffay
Copy link
Member Author

Now the CI fails because of recent change in minikube release kubernetes/minikube#2629

@pavolloffay
Copy link
Member Author

CI passed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants