Add docs for sampling #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
commented
Dec 15, 2021
| message PerOperationSamplingStrategies { | ||
| // Default sampling probability for TraceIdRatioBased sampler. |
There was a problem hiding this comment.
@yurishkuro I think comments in this type need more explanation.
The per-operation config is clear - it is used if names match, if name does not match does it fallback to the probabilistic and rate limiting sampler? Is the rate limiting sampler used first until a specified throughput is satisfied and then it is switched to probabilistic?
yurishkuro
reviewed
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yurishkuro could you please review?
This was originally added here open-telemetry/opentelemetry-specification#2222 but moving here as the spec will reference this file.