This repository has been archived by the owner on May 23, 2024. It is now read-only.
Rename to jaegar config mgr host port #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an other method with config receiver and modified the existing method to call the method with config receiver. Resolves: 430 Signed-off-by: vineeth <[email protected]>
…tests. Signed-off-by: vineeth <[email protected]>
… tests Signed-off-by: vineeth <[email protected]> made chnages to support allow FromEnv for sampler and reporter + Unit tests Signed-off-by: vineeth <[email protected]>
Signed-off-by: vineeth <[email protected]>
I made renmaing in three places including the comment lines and README for better understanding and to eliminate inconsistency. Signed-off-by: vineeth <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
#282