This repository has been archived by the owner on May 23, 2024. It is now read-only.
Print error on Sampler Query failure #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 87.14% 87.21% +0.07%
==========================================
Files 54 54
Lines 2988 2989 +1
==========================================
+ Hits 2604 2607 +3
+ Misses 272 271 -1
+ Partials 112 111 -1
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Aug 29, 2018
sampler.go
Outdated
| @@ -511,6 +511,7 @@ func (s *RemotelyControlledSampler) updateSampler() { | |||
| res, err := s.manager.GetSamplingStrategy(s.serviceName) | |||
| if err != nil { | |||
| s.metrics.SamplerQueryFailure.Inc(1) | |||
| s.logger.Infof("Unable to query sampling strategy. Got error: %v", err) | |||
There was a problem hiding this comment.
simplify the message: s.logger.Infof("Unable to query sampling strategy: %v", err)
can you add a unit test?
There was a problem hiding this comment.
e.g.
jaeger-client-go/reporter_test.go
Line 97 in f7e0d47
There was a problem hiding this comment.
preferably use string.Contains()
Signed-off-by: Goutham Veeramachaneni <[email protected]>
yurishkuro
approved these changes
Sep 3, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327