This repository has been archived by the owner on May 23, 2024. It is now read-only.
Document that JAEGER_SAMPLER_MANAGER_HOST_PORT should be a URL #326
Comments
|
#327 for the error log part |
lw346
added a commit
to lw346/jaeger-client-java
that referenced
this issue
Sep 15, 2018
Introduce a new property, JAEGER_CONFIG_MANAGER_ENDPOINT, that should be set to the URL of the Jaeger Config Manager sampling endpoint. If not set, fall back to the now-deprecated JAEGER_SAMPLER_MANAGER_HOST_PORT as the host and port of the URL. If JAEGER_AGENT_HOST has been set as a property, further fall back to that value as the host of the URL (using the default port of 5778). This brings the SamplerConfiguration in-line with the Go client. See also: * jaegertracing#521 * jaegertracing#547 * jaegertracing/jaeger-client-go#326 * jaegertracing/jaeger-client-go#282 Signed-off-by: Luke Wood <[email protected]>
lw346
added a commit
to lw346/jaeger-client-java
that referenced
this issue
Sep 15, 2018
Introduce a new property, JAEGER_CONFIG_MANAGER_ENDPOINT, that should be set to the URL of the Jaeger Config Manager sampling endpoint. If not set, fall back to the now-deprecated JAEGER_SAMPLER_MANAGER_HOST_PORT as the host and port of the URL. If JAEGER_AGENT_HOST has been set as a property, further fall back to that value as the host of the URL (using the default port of 5778). This brings the SamplerConfiguration in-line with the Go client. See also: * jaegertracing#521 * jaegertracing#547 * jaegertracing/jaeger-client-go#326 * jaegertracing/jaeger-client-go#282 Signed-off-by: Luke Wood <[email protected]>
lw346
added a commit
to lw346/jaeger-client-java
that referenced
this issue
Sep 15, 2018
Introduce a new property, JAEGER_CONFIG_MANAGER_ENDPOINT, that should be set to the URL of the Jaeger Config Manager sampling endpoint. If not set, fall back to the now-deprecated JAEGER_SAMPLER_MANAGER_HOST_PORT as the host and port of the URL. If JAEGER_AGENT_HOST has been set as a property, further fall back to that value as the host of the URL (using the default port of 5778). This brings the SamplerConfiguration in-line with the Go client. See also: * jaegertracing#521 * jaegertracing#547 * jaegertracing/jaeger-client-go#326 * jaegertracing/jaeger-client-go#282 Signed-off-by: Luke Wood <[email protected]>
lw346
added a commit
to lw346/jaeger-client-java
that referenced
this issue
Sep 15, 2018
Introduce a new property, JAEGER_CONFIG_MANAGER_ENDPOINT, that should be set to the URL of the Jaeger Config Manager sampling endpoint. If not set, fall back to the now-deprecated JAEGER_SAMPLER_MANAGER_HOST_PORT as the host and port of the URL. If JAEGER_AGENT_HOST has been set as a property, further fall back to that value as the host of the URL (using the default port of 5778). This brings the SamplerConfiguration in-line with the Go client. See also: * jaegertracing#521 * jaegertracing#547 * jaegertracing/jaeger-client-go#326 * jaegertracing/jaeger-client-go#282 Signed-off-by: Luke Wood <[email protected]>
lw346
added a commit
to lw346/jaeger-client-java
that referenced
this issue
Sep 15, 2018
Introduce a new property, JAEGER_CONFIG_MANAGER_ENDPOINT, that should be set to the URL of the Jaeger Config Manager sampling endpoint. If not set, fall back to the now-deprecated JAEGER_SAMPLER_MANAGER_HOST_PORT as the host and port of the URL. If JAEGER_AGENT_HOST has been set as a property, further fall back to that value as the host of the URL (using the default port of 5778). This brings the SamplerConfiguration in-line with the Go client. See also: * jaegertracing#521 * jaegertracing#547 * jaegertracing/jaeger-client-go#326 * jaegertracing/jaeger-client-go#282 Signed-off-by: Luke Wood <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now the documentation says:
The host name and port when using the remote controlled sampler. This is super vague and this led me to believe I should set it to:jaeger-agent.jaeger.svc:5778, when infact it should be:http://jaeger-agent.jaeger.svc:5778/samplingFurther, the error here is being just dropped on the floor: https://github.com/jaegertracing/jaeger-client-go/blob/master/sampler.go#L397-L399 making debugging super hard.
The text was updated successfully, but these errors were encountered: