This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Document that the Thrift generated files are patched #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=======================================
Coverage 88.46% 88.46%
=======================================
Files 93 93
Lines 2246 2246
=======================================
Hits 1987 1987
Misses 259 259Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Jan 31, 2018
|
@ringerc could you please amend the commit to make it signed? |
Signed-off-by: Craig Ringer <[email protected]>
ringerc
force-pushed
the
document-patched-idl
branch
from
03219f0 to
b2dc8ad
Compare
|
@yurishkuro Done |
isaachier
approved these changes
Feb 1, 2018
|
Awesome work! Thank you for the docs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #45, document that the code-gen output from the IDL is currently patched from the original generated code, and why.