Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Fix yaml-cpp issues (#36) #39

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

isaachier
Copy link
Contributor

Signed-off-by: Isaac Hier [email protected]

@codecov
Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #39 into master will increase coverage by 3.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   85.22%   88.46%   +3.24%     
==========================================
  Files          93       93              
  Lines        2240     2246       +6     
  Branches      206        0     -206     
==========================================
+ Hits         1909     1987      +78     
- Misses        253      259       +6     
+ Partials       78        0      -78
Impacted Files Coverage Δ
src/jaegertracing/Config.h 95.23% <ø> (+4.76%) ⬆️
src/jaegertracing/baggage/RestrictionsConfig.h 100% <ø> (+8.33%) ⬆️
src/jaegertracing/propagation/HeadersConfig.h 100% <ø> (+4.16%) ⬆️
...egertracing/samplers/RemotelyControlledSampler.cpp 60.91% <0%> (-0.71%) ⬇️
src/jaegertracing/Span.h 93% <0%> (+1%) ⬆️
src/jaegertracing/SpanContext.h 98.27% <0%> (+3.44%) ⬆️
src/jaegertracing/samplers/Config.h 53.7% <0%> (+3.7%) ⬆️
src/jaegertracing/net/URI.h 100% <0%> (+4.54%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d5602...9488b5e. Read the comment docs.

Copy link

@black-adder black-adder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the issue?

@isaachier
Copy link
Contributor Author

I used a tool to optimize my #includes, but it totally undermined the case when certain libraries weren't installed, so had to fix here.

@isaachier isaachier merged commit 67a9092 into jaegertracing:master Jan 24, 2018
@isaachier isaachier deleted the yaml-cpp-iwyu-fix branch January 24, 2018 21:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants