This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Add language prefix to Jaeger client version tag #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Hier <[email protected]>
isaachier
force-pushed
the
add-lang-to-version-tag
branch
from
ae189ac to
b8c769a
Compare
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 85.49% 85.22% -0.27%
==========================================
Files 93 93
Lines 2240 2240
Branches 206 206
==========================================
- Hits 1915 1909 -6
Misses 253 253
- Partials 72 78 +6
Continue to review full report at Codecov.
|
|
The coverage seems to have a mistake. IDK why it thinks the coverage went down on BaggageSetter. |
yurishkuro
reviewed
Dec 17, 2017
| ASSERT_NE(std::end(tracer->tags()), tagItr); | ||
| ASSERT_TRUE(tagItr->value().is<const char*>()); | ||
| ASSERT_EQ("C++-", | ||
| static_cast<std::string>(tagItr->value().get<const char*>()).substr(0, 4)); |
There was a problem hiding this comment.
omg... this would've been one line in scala. Let me try:
assert(span.tags.find(_.key == 'jaeger.version').map(_.value) == Some('c++-..'))
There was a problem hiding this comment.
Lol ya C++ has borrowed a lot of ideas from more functional languages but nowhere near Scala and others yet.
yurishkuro
approved these changes
Dec 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34.