This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Added support for setting tracer tags via the configuration #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tobias Stadler <[email protected]>
|
@yurishkuro would mind doing a review please? |
|
✅ Build jaeger-client-cpp 241 completed (commit 52476643f6 by @tobiasstadler) |
yurishkuro
approved these changes
Sep 4, 2021
|
✅ Build jaeger-client-cpp 244 completed (commit 3d54e072fd by @yurishkuro) |
|
@yurishkuro The build failure in macOS seems to be unrelated to my change. |
|
@yurishkuro Could you rerun the build please |
|
restarted |
|
Thank you! Would you be so kind and do a release please? |
|
Released in 0.8.0 |
|
Thank You! |
|
Nevermind. Tested and it works.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
At the moment setting the tracer tags is only possible via an environment variable. It should also be possible to set them via the configuration (file).
Short description of the changes