This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Support configuration for generating 128 bit trace ids #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tobias Stadler <[email protected]>
|
❌ Build jaeger-client-cpp 164 failed (commit 75985a4f2d by @tobiasstadler) |
|
To clarify, the PR is adding configuration support for 128bit IDs, correct? Not the actual support in the tracer. |
|
Yes, I only added configuration support. Sorry, the title is a bit misleading. |
tobiasstadler
changed the title
|
I updated the title. Should I also change the commit message? |
|
Thanks. The PR title is enough, we squash the commits during merge. |
yurishkuro
changed the title
This was referenced Dec 7, 2020
yurishkuro
approved these changes
Jan 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes