This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Add jaeger-debug-id as a tag #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the trace was started with a debugID, adding jaeger-debug-id as tag ensures that the trace will be sampled in the "debug" mode. Additionally, the root span will have this ID as a searchable tag. Resolves: jaegertracing#136 Signed-off-by: Chris Goller <[email protected]>
|
✅ Build jaeger-client-cpp 49 completed (commit 530a6ec343 by @goller) |
|
please use |
yurishkuro
reviewed
Nov 21, 2019
| @@ -85,6 +86,7 @@ Tracer::StartSpanWithOptions(string_view operationName, | |||
| flags |= | |||
| (static_cast<unsigned char>(SpanContext::Flag::kSampled) | | |||
| static_cast<unsigned char>(SpanContext::Flag::kDebug)); | |||
| samplerTags.push_back(Tag(kJaegerDebugHeader, parent->debugID())); | |||
There was a problem hiding this comment.
is there a unit test which can check that?
There was a problem hiding this comment.
Hey @yurishkuro thanks for the review; tests added in 7d81527
Signed-off-by: Chris Goller <[email protected]>
|
✅ Build jaeger-client-cpp 51 completed (commit 3c1cf9c627 by @goller) |
yurishkuro
approved these changes
Nov 23, 2019
|
Woot! Thanks !
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
resolves #136
Short description of the changes
If the trace was started with a debugID, adding jaeger-debug-id
as tag ensures that the trace will be sampled in the "debug" mode.
Additionally, the root span will have this ID as a searchable tag.