Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Improve documentation #33

Closed
isaachier opened this issue Dec 12, 2017 · 6 comments
Closed

Improve documentation #33

isaachier opened this issue Dec 12, 2017 · 6 comments

Comments

@isaachier
Copy link
Contributor

Self-explanatory issue

@ringerc
Copy link
Contributor

ringerc commented Jan 25, 2018

Would be good to have a quickstart example mentioning:

ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Jan 26, 2018
@ringerc
Copy link
Contributor

ringerc commented Jan 26, 2018

@isaachier Wrote a draft for you. Code examples need checking, and I'm sure you can correct the bits I got wrong, but it should help. See above-linked commit.

ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Jan 28, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Jan 31, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Jan 31, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 1, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 2, 2018
ringerc added a commit to ringerc/jaeger-cpp-client that referenced this issue Feb 13, 2018
@manannayak
Copy link

Thanks a lot of writing it up, Craig!

Btw - is there a plan to merge this into master?

@isaachier
Copy link
Contributor Author

Unfortunately this isn't a pull request, it's an issue. Also, it is probably outdated at this point.

@yurishkuro
Copy link
Member

Looks like the content is in a branch, that can be converted to a PR. Don't know about it being up to date.

@isaachier
Copy link
Contributor Author

I think this was part of a much bigger P.R. I ultimately closed due to merge conflicts and no response from @ringerc (who is too busy to fix it at the moment). See #46.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants