Create files to allow us to fix the listing on Artifacthub #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Kowall <[email protected]>
Signed-off-by: Jonah Kowall <[email protected]>
jkowall
requested review from
davidvonthenen,
naseemkullah and
pavelnikolov
as code owners
jkowall
changed the title
yurishkuro
reviewed
Apr 21, 2024
charts/jaeger/Chart.yaml
Outdated
Comment on lines
2
to
6
| appVersion: 1.56.0 | ||
| description: A Jaeger Helm chart for Kubernetes | ||
| name: jaeger | ||
| type: application | ||
| version: 3.0.0 | ||
| version: 3.0.1 |
There was a problem hiding this comment.
maybe avoid these changes with an otherwise administrative PR
There was a problem hiding this comment.
The chart version must be bumped. Hence makes sense to bump jaeger too.
There was a problem hiding this comment.
yes, but it should be a separate PR dedicated to bumping version
There was a problem hiding this comment.
The chart version, indeed, needs to be bumped with every change. However, the Jaeger version bumped needs to be a separate PR.
|
it seems this chart is already listed https://artifacthub.io/packages/helm/jaegertracing/jaeger, but it's missing all the "official" badges. 
In contrast, Prometheus: 
|
Signed-off-by: Jonah Kowall <[email protected]>
yurishkuro
approved these changes
Apr 22, 2024
pavelnikolov
approved these changes
Apr 22, 2024
|
Will reopen now that my signing is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a file for us to identify this repo as the official chart. This will allow me to correct the listing as official and fix a security gap. I added myself to the Chart and new artifacthub-repo.yml.
I have also bumped the version for Jaeger to current and changed the version of the chart.
Which issue this PR fixes
jaegertracing/jaeger#5363
Checklist
[jaeger]or[jaeger-operator])