Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger] Fix otlp service regression in 0.71.5 #479

Merged
merged 3 commits into from
Jun 23, 2023
Merged

[jaeger] Fix otlp service regression in 0.71.5 #479

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8500d1b
Fix otlp service regression in 0.71.5
spadger Jun 23, 2023
8ba20b0
Make otlp ports configurable on deployment
spadger Jun 23, 2023
4cf24b0
Revert otlp ports to original format i.e. otlp-<protocol>
spadger Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/jaeger/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: 1.45.0
description: A Jaeger Helm chart for Kubernetes
name: jaeger
type: application
version: 0.71.5
version: 0.71.6
# CronJobs require v1.21
kubeVersion: '>= 1.21-0'
keywords:
Expand Down
8 changes: 4 additions & 4 deletions charts/jaeger/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ allInOne:
collector:
otlp:
grpc:
name: gtpc-otlp
name: otlp-grpc
http:
name: http-otlp
name: otlp-http
ingress:
enabled: false
# For Kubernetes >= 1.18 you should specify the ingress-controller via the field ingressClassName
Expand Down Expand Up @@ -379,11 +379,11 @@ collector:
# nodePort:
otlp:
grpc:
name: grpc-otlp
name: otlp-grpc
# port: 4317
# nodePort:
http:
name: http-otlp
name: otlp-grpc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: otlp-grpc
name: otlp-http

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right that this was a mistake, but the actual format should have been http-otlp. Otherwise, we'd have caused a regression you attempted to fix in 0.71.5!

# port: 4318
# nodePort:
ingress:
Expand Down