Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-operator] Add cert machinery #368

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Conversation

czomo
Copy link
Contributor

@czomo czomo commented May 27, 2022

Signed-off-by: czomo [email protected]

What this PR does

Adding cert, weebhooks to adapt chart to jaeger-operator v.1.32+

Which issue this PR fixes

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

@czomo czomo requested review from batazor and cpanato as code owners May 27, 2022 23:10
@czomo czomo changed the title WIP jaeger-operator Add cert machinery WIP: jaeger-operator Add cert machinery May 27, 2022
@avishefi
Copy link

The cert-manager Issuer and Certificate should be configurable and optionally excluded as not all admins want an additional dedicated self-signed issuer just for Jaeger Operator. The dependency is not on cert-manager, but on a tls certificate stored in a secret that should be renewed automatically where cert-manager is the default supported creation and renewal method.

I think it should be possible to customize the Issuer and Certificate details (name, issuer, certificate details, etc.), and on top of that to completely disable the Issuer and Certificate and pass the tls secret name instead.

@czomo czomo changed the title WIP: jaeger-operator Add cert machinery jaeger-operator Add cert machinery May 31, 2022
@czomo
Copy link
Contributor Author

czomo commented May 31, 2022

@avishefi Thanks for pointing this out. I appreciate the review! I've made the certificate and issuer optional.

@avishefi
Copy link

@avishefi Thanks for pointing this out. I appreciate the review! I've made the certificate and issuer optional.

Thanks!

@czomo czomo changed the title jaeger-operator Add cert machinery [jaeger-operator] Add cert machinery Jun 4, 2022
@czomo
Copy link
Contributor Author

czomo commented Jun 6, 2022

@cpanato @batazor Could you take a look? I've fixed the github actions test

@batazor
Copy link
Member

batazor commented Jun 6, 2022

@czomo Hi. Can we rebase commits?

@czomo
Copy link
Contributor Author

czomo commented Jun 6, 2022

@batazor Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants