-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger-operator] Add cert machinery #368
Conversation
The cert-manager Issuer and Certificate should be configurable and optionally excluded as not all admins want an additional dedicated self-signed issuer just for Jaeger Operator. The dependency is not on cert-manager, but on a tls certificate stored in a secret that should be renewed automatically where cert-manager is the default supported creation and renewal method. I think it should be possible to customize the Issuer and Certificate details (name, issuer, certificate details, etc.), and on top of that to completely disable the Issuer and Certificate and pass the tls secret name instead. |
@avishefi Thanks for pointing this out. I appreciate the review! I've made the certificate and issuer optional. |
Thanks! |
@czomo Hi. Can we rebase commits? |
Signed-off-by: czomo <[email protected]>
@batazor Done! |
Signed-off-by: czomo [email protected]
What this PR does
Adding cert, weebhooks to adapt chart to jaeger-operator v.1.32+
Which issue this PR fixes
Checklist
[jaeger]
or[jaeger-operator]
)