[jaeger-operator] Synchronize cluster role template with jaeger operator #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I ask you guys to merge this fix ? Thanks |
|
Sorry for not looking into this earlier, I was waiting for a maintainer of the Helm chart to take a look first. In any case, I approved the run. Could you please sort out the DCO check? |
majidazimi
requested review from
davidvonthenen,
naseemkullah and
pavelnikolov
as code owners
majidazimi
force-pushed
the
main
branch
2 times, most recently
from
b3b78d0 to
7f103de
Compare
majidazimi
changed the title
|
I bumped chart version to |
|
@majidazimi, I was about to merge this, but realized that you haven't signed your commit and this repository requires signing (!!). Are you able to sign it?
|
Signed-off-by: Majid Azimi <[email protected]>
Signed-off-by: Majid Azimi <[email protected]>
|
ok signed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster role template wasn't reflecting the same level of permissions as upstream jaeger-operator. This PR makes helm chart follow upstream.
The issue is discussed here: #250