[jaeger] Add secret volume for cassandra tls #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 하광일/TC_Core Engineering <[email protected]>
|
solves #15 Thanks @kwangil-ha! Just missing the chart version bump and we should be good to go! |
|
LGTM |
|
@kwangil-ha re: chart version bump, that would be here: helm-charts/charts/jaeger/Chart.yaml Line 5 in 31ae789 |
naseemkullah
changed the title
|
Hi, @yurishkuro any specific reason to close this PR? |
|
I don't remember closing it. It may have happened after renaming master->main branch. I can't reopen it either, it says source repo was deleted. |
|
Thanks for confirming it @yurishkuro I will open new PR with these fixes as #15 is kind of blocking us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 하광일/TC_Core Engineering [email protected]