Added documentation about cluster-wide permissions for the operator #370
Conversation
|
@pavolloffay, if this looks good, I'll merge the referenced issue (as soon as it passes the CI checks) and release the operator. |
| ```bash | ||
| kubectl create namespace observability # <1> | ||
| kubectl create -f https://raw.githubusercontent.com/jaegertracing/jaeger-operator/master/deploy/crds/jaegertracing.io_jaegers_crd.yaml # <2> | ||
| kubectl create -f https://raw.githubusercontent.com/jaegertracing/jaeger-operator/master/deploy/service_account.yaml |
There was a problem hiding this comment.
Would it be possible to update the links in older releases to use pined versions and not master so they still work?
There was a problem hiding this comment.
I think we should start doing it from now. There were changes to these files+namespaces in the past, and I'm not sure it makes sense to spend time making sure that the old instructions work.
There was a problem hiding this comment.
I see that the master is used in the next-release. Therefore the release script should be changed to change the master to the version being released.
I have created #372
| ```bash | ||
| kubectl create namespace observability # <1> | ||
| kubectl create -f https://raw.githubusercontent.com/jaegertracing/jaeger-operator/master/deploy/crds/jaegertracing.io_jaegers_crd.yaml # <2> | ||
| kubectl create -f https://raw.githubusercontent.com/jaegertracing/jaeger-operator/master/deploy/service_account.yaml |
There was a problem hiding this comment.
I see that the master is used in the next-release. Therefore the release script should be changed to change the master to the version being released.
I have created #372
|
@pavolloffay I think I addressed all the open points. Could you please review again? |
|
PR updated to address @JStickler's comments. |
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
StreamlinePermissions
branch
from
fa34540 to
0a35d66
Compare
|
I'm merging this as I can work on any further changes in a future PR. |
Signed-off-by: Juraci Paixão Kröhling [email protected]
Which problem is this PR solving?