Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Jellyfin and Podcasts browse tiles #844

Merged
merged 5 commits into from
Jun 18, 2022
Merged

Conversation

phampyk
Copy link
Contributor

@phampyk phampyk commented May 26, 2022

Fix Soma FM tile not showing and added Jellyfin and podcasts tiles
Background images from unsplash
Jellyfin icon from their website
Microphone icon from icons8.com

jaedb and others added 3 commits May 14, 2022 13:43
Fix Soma FM tile not showing and added Jellyfin and podcasts tiles
Copy link
Owner

@jaedb jaedb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The files you've edited are all in the compiled codebase. For your contribution to be persistent, you will need to edit the source files instead.

Everything you need is in the /src directory.

Comment on lines 188344 to 188353
case 'SomaFM':
subdirectory.icons = ['/iris/assets/backgrounds/browse-somafm.jpg'];
break;

case 'Jellyfin':
subdirectory.icons = ['/iris/assets/backgrounds/browse-jellyfin.jpg'];
break;

case 'Podcasts':
subdirectory.icons = ['/iris/assets/backgrounds/browse-podcasts.jpg'];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These edits are in the compiled application code and will be overwritten next time it is compiled.

Instead, you want to editing the source file: https://github.com/jaedb/Iris/blob/master/src/js/views/Library/Browse.js#L86-L88

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for letting me know where to do the change, I hope now everything is right.
And thank you for your work too, is very useful for me :)

@jaedb jaedb changed the title New tiles Adding Jellyfin and Podcasts browse tiles May 26, 2022
@phampyk phampyk requested a review from jaedb May 27, 2022 17:36
@jaedb jaedb changed the base branch from master to develop June 18, 2022 08:37
@jaedb jaedb merged commit 8c42bb1 into jaedb:develop Jun 18, 2022
@jaedb
Copy link
Owner

jaedb commented Jun 18, 2022

FYI you forgot to relocate your images into the src folder. Something to remember for next time! Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants