Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker/entrypoint.sh to allow for sideloading of PIP packages (e.g. additional mopidy plugins) #783

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

BasVanBoven
Copy link
Contributor

@BasVanBoven BasVanBoven commented Oct 30, 2021

On the Wiki, I would also add a sixth list item under ¨Getting-started > To install using Docker¨ to explain the new functionality:

  1. If you want to sideload additional PIP packages to your Docker container, these can be specified using the PIP_PACKAGES environment variable, demarcated by a space between different packages

@jaedb
Copy link
Owner

jaedb commented Oct 31, 2021

Looks good! For users who wish to install additional packages, would this not re-install them every time the container was started? Naturally the delay to startup would be wholly dependent on the size and quantity of packages.
Is there a more efficient way we could tackle this by using volumes?

@BasVanBoven
Copy link
Contributor Author

Hmm, that certainly is an interesting thought! However, for that to work I think we'd have to let pip store the custom package someplace else than the default location, make python read packages from there (perhaps through a path variable?) and also add a volume mount point. I do not know if it is possible to set that up. Also, it would introduce a lot of complexity for the adding of 1-2 packages use case.

@jaedb jaedb changed the base branch from master to develop November 19, 2021 23:13
@jaedb jaedb merged commit 9f46aa7 into jaedb:develop Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants