Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember scroll position on navigate #618

Closed
tperich opened this issue Oct 2, 2020 · 3 comments
Closed

Remember scroll position on navigate #618

tperich opened this issue Oct 2, 2020 · 3 comments

Comments

@tperich
Copy link

tperich commented Oct 2, 2020

First of all, this is a really great project, and I love it.

Is your feature request related to a problem? Please describe.
It would be really nice if the app remembered scroll positions, especially when entering and then exiting playlists.

Describe the solution you'd like
We can implement this through DOM's scrollY and store it in state.

Describe alternatives you've considered
Maybe a hook?

Additional context
I'd be willing to write the code myself, just wanted to get other thoughts on implementing this.

@jaedb
Copy link
Owner

jaedb commented Oct 11, 2020

This - while not great with lazy-loading - already exists. Check out the restorer here: https://github.com/jaedb/Iris/blob/master/src/js/App.js#L189-L195.

I am currently overhauling the loading and remote fetching processes which will indirectly make it easier to restore scroll position on lazy-loaded lists/grids. Please note this won't change navigating into a playlists, just using the browser's Back and Forwards navigation buttons.

Is this in line with what you're suggesting?

@atrizdawiz
Copy link

I would like this feature also. I'm attaching a gif of current behavior. The expected behavior is that going back centers on the album I just clicked on.
please-remember

@jaedb
Copy link
Owner

jaedb commented Mar 18, 2021

Resolved in 3.57.0

@jaedb jaedb closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants