Skip to content

Commit

Permalink
Fix device type metadata for bridge device types. (project-chip#36034)
Browse files Browse the repository at this point in the history
* Bridged Node was named wrong.
* Aggregator had a class listed that did not match the spec.
  • Loading branch information
bzbarsky-apple authored Oct 11, 2024
1 parent a76cc9b commit 18bcd0c
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 9 deletions.
6 changes: 3 additions & 3 deletions src/app/zap-templates/zcl/data-model/chip/matter-devices.xml
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ limitations under the License.
<typeName>Matter Aggregator</typeName>
<profileId editable="false">0x0103</profileId>
<deviceId editable="false">0x000e</deviceId>
<class>Dynamic Utility</class>
<class>Simple</class>
<scope>Endpoint</scope>
<clusters lockOthers="true">
<include cluster="Descriptor" client="false" server="true" clientLocked="true" serverLocked="true">
Expand All @@ -190,9 +190,9 @@ limitations under the License.
</clusters>
</deviceType>
<deviceType>
<name>MA-bridgeddevice</name>
<name>MA-bridgednode</name>
<domain>CHIP</domain>
<typeName>Matter Bridged Device</typeName>
<typeName>Matter Bridged Node</typeName>
<profileId editable="false">0x0103</profileId>
<deviceId editable="false">0x0013</deviceId>
<class>Utility</class>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ struct DeviceTypeData {
constexpr DeviceTypeData knownDeviceTypes[] = {
{{#zcl_device_types}}
{{#if class}}
{{! For now work around the "Dynamic Utility" thing on Aggregator by just
taking the last word. }}
{ {{asHex code 8}}, DeviceTypeClass::{{asLastWord class}}, "{{caption}}" },
{ {{asHex code 8}}, DeviceTypeClass::{{class}}, "{{caption}}" },
{{/if}}
{{/zcl_device_types}}
};
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 18bcd0c

Please sign in to comment.