f773496775 access table structure's digest should be trusted #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some setups (in my case macOS v14.4.1 (build 23E224) and macOS v14.2.1 (build 23C71) with Intel CPU) the computed digest on the access table's structure was not part of the expected macOS 14.x digests. By comparing working and non-working output of `SELECT sql FROM sqlite_master WHERE name='access' and type='table'` I've discovered the only difference is cosmetic: a double-quote around access in the `CREATE TABLE` part (got `CREATE TABLE "access"` where `CREATE TABLE access` would have been accepted Before a possible better fix to handle such small syntax changes, this commit adds f773496775 to the list of trusted digests. Issue: jacobsalmela#70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #70 by adding
f773496775to the list of macOS 14 trusted access table structure's digests because it's a simple variation of an already trusted one.The
SELECT sql FROM sqlite_master WHERE name='access' and type='table'was producing the almost-same SQL:Note: This is a "simple" fix. A better one would be to lint obtained SQL in a common format.
Feel free to comment with more information.